Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cbindgen 0.5.0 require nightly #137

Closed
hfiguiere opened this issue Feb 25, 2018 · 5 comments · Fixed by #143
Closed

cbindgen 0.5.0 require nightly #137

hfiguiere opened this issue Feb 25, 2018 · 5 comments · Fixed by #143

Comments

@hfiguiere
Copy link

cbindgen 0.5.0 (unlike 0.4.3). And that's a showstopper to be used in a project that works with stable channel compiler. This caused by rustc-ap-serialize v40.0.0.
@RReverser
Copy link
Contributor

Looks like duplicate of #136

@hfiguiere
Copy link
Author

Kinda. #136 is about a minor version requiring unstable Rust. This one is the newer one requiring it. And lack of release notes doesn't help determine whether it's worth it.

@RReverser
Copy link
Contributor

Sure, I meant that #136 had explanation on what happened and how it led to publishing of 0.5.0

@eqrion
Copy link
Collaborator

eqrion commented Feb 26, 2018

This should be able to be fixed once dtolnay/syn#363 is resolved.

@staktrace
Copy link
Contributor

Since dtolnay wants to wait to publish the updated quote and syn crates until he has collected more breaking changes, I landed those PRs (dtolnay/quote#62 and dtolnay/syn#363) into my standalone-quote and standalone-syn crates with version bumps to 0.5.0 and 0.13.0 respectively. So if we update cbindgen to use those we can drop the nightly compile requirement. I'll submit a PR for that. It will also ease the transition to when those PRs get merged and we can get back to the regular upstream repos.

staktrace added a commit to staktrace/cbindgen that referenced this issue Mar 5, 2018
@staktrace
Bump to standalone-syn 0.13.0
3291785 
Fixes mozilla#137.

standalone-syn 0.13.0 contains the deferred PR dtolnay/syn#363 which
allows turning off the "proc-macro" feature. This is the desired
approach to fixing the dylib dependency problem, and allows cbindgen to
once again be buildable by the release rustc compiler.
@staktrace staktrace mentioned this issue Mar 5, 2018
Merged
eqrion pushed a commit that referenced this issue Mar 6, 2018
@staktrace @eqrion
Bump to standalone-syn 0.13.0
03ea684 
Fixes #137.

standalone-syn 0.13.0 contains the deferred PR dtolnay/syn#363 which
allows turning off the "proc-macro" feature. This is the desired
approach to fixing the dylib dependency problem, and allows cbindgen to
once again be buildable by the release rustc compiler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump to standalone-syn 0.13.0 staktrace/cbindgen
4 participants
@hfiguiere @staktrace @RReverser @eqrion