Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sw cache list to include ConsoleManager and whitespace extension #675

Merged
merged 1 commit into from
Mar 31, 2017

Conversation

humphd
Copy link

@humphd humphd commented Mar 30, 2017

Before we update prod, I need this to land so that we cache the new files we've added in recent commits to our service worker cache.

NOTE: this is going to get simplified in #634, where I'll just tell it to use everything in dist/ so we don't miss files. I need to land a few patches before that, though, so this is a stop-gap.

@humphd
Copy link
Author

humphd commented Mar 30, 2017

If you want to test this:

  • npm build and grunt swPrecache
  • npm start
  • load http://localhost:8000/dist/hosted.html (note the dist/ vs. src/)
  • Open your web console, go offline, refresh
  • It should load again.

There is one file that will be 404, the client/main.js, which is just a thing with require, not a real bug.

@Pomax Pomax self-requested a review March 30, 2017 20:58
@Pomax
Copy link

Pomax commented Mar 30, 2017

  • make sure cache-disable-with-dev-tools is NOT on
  • application -> service workers fiddle with "update on reload" and "bypass for network"

@gideonthomas
Copy link

r+ since this is a temporary fix

@humphd humphd merged commit 18ce4af into mozilla:master Mar 31, 2017
Rajat-dhyani pushed a commit to Rajat-dhyani/brackets that referenced this pull request Apr 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants