Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNTOR-3378 - Data broker manual removal #5287

Open
wants to merge 46 commits into
base: main
Choose a base branch
from
Open

MNTOR-3378 - Data broker manual removal #5287

wants to merge 46 commits into from

Conversation

codemist
Copy link
Collaborator

@codemist codemist commented Nov 4, 2024 •
edited
Loading

References:

Jira: MNTOR-3378
Figma: https://www.figma.com/design/DTbmXzCQCw2PxXpHQW8yfW/Monitor-MVP-Enhancements?node-id=3809-6501&t=EniBV7WqvPVnuivk-4

Path: /user/dashboard/fix/data-broker-profiles/removal-under-maintenance

Description

Screenshot (if applicable)

image image image

Not applicable.

How to test

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug.
  • If this PR implements a feature flag or experimentation, the Ship Behind Feature Flag status in Jira has been set
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

codemist
codemist commented Nov 4, 2024
View reviewed changes
src/app/functions/universal/scanResult.ts
Comment on lines +11 to +12
| "removed"
| "removal_under_maintenance";
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhelmer I believe this would be our first time consuming this endpoint for the manual data broker removal feature.

@codemist codemist requested a review from rhelmer November 4, 2024 19:20
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

@codemist codemist marked this pull request as ready for review November 12, 2024 18:53
@codemist codemist added the 🛑 Do Not Merge Do not merge this PR, even if approved. label Nov 12, 2024
@codemist codemist requested a review from flozia November 12, 2024 18:56
@github-actions GitHub Actions
Copy link

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

@github-actions GitHub Actions
Copy link

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

2 similar comments
@github-actions GitHub Actions
Copy link

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

@github-actions GitHub Actions
Copy link

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

@github-actions GitHub Actions
Copy link

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

@github-actions GitHub Actions
Copy link

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

@github-actions GitHub Actions
Copy link

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

@github-actions GitHub Actions
Copy link

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

@github-actions GitHub Actions
Copy link

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flozia flozia flozia left review comments

@flodolo flodolo flodolo approved these changes

@rhelmer rhelmer Awaiting requested review from rhelmer

Assignees
No one assigned
Labels
🛑 Do Not Merge Do not merge this PR, even if approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codemist @flodolo @flozia @mansaj