Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional tests for blocklisted breach resolution links #3000

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

flozia
Copy link
Collaborator

@flozia flozia commented Apr 19, 2023

Additional tests for the blocked company domain links in the breach resolution as requested and promised in #2961 (comment).

@flozia flozia requested a review from Vinnl April 19, 2023 08:51
Copy link
Collaborator

@Vinnl Vinnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Does t.is do partial matches? (Since you were able to add the part about the password manager without updating the code.)

src/utils/breachResolution.test.js Outdated Show resolved Hide resolved
@flozia flozia force-pushed the link-blocklist-tests branch from 55f5da7 to a3ce2cf Compare April 19, 2023 15:08
@flozia flozia force-pushed the link-blocklist-tests branch from a3ce2cf to fb55236 Compare April 19, 2023 15:10
@flozia
Copy link
Collaborator Author

flozia commented Apr 19, 2023

Looking good! Does t.is do partial matches? (Since you were able to add the part about the password manager without updating the code.)

That change was originally introduced in another PR by 94152f5. I messed something up while cherry-picking — fixed!

@flozia flozia merged commit 9e142bc into main Apr 19, 2023
@flozia flozia deleted the link-blocklist-tests branch April 19, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants