Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy per-app Glean usage ETL #895

Closed
wants to merge 2 commits into from
Closed

Conversation

jklukas
Copy link
Contributor

@jklukas jklukas commented Apr 9, 2020

The incline dashboard, KPIs, and GUD are now referencing the generic glean ETL
(baseline_clients_daily and baseline_clients_last_seen), so these other
tables should no longer be needed.

I also need to remove these from Airflow and I will need to send out a message
to fx-data-dev to advertise this breaking change, but I doubt there's much
usage so far of these legacy tables since they have not been well documented
or advertised; they existed primarily to serve GUD, Incline, and KPIs.

@jklukas jklukas requested a review from fbertsch April 9, 2020 19:56
jklukas added 2 commits April 10, 2020 09:14
The incline dashboard, KPIs, and GUD are now referencing the generic glean ETL
(baseline_clients_daily and baseline_clients_last_seen), so these other
tables should no longer be needed.

I also need to remove these from Airflow and I will need to send out a message
to fx-data-dev to advertise this breaking change, but I doubt there's much
usage so far of these legacy tables since they have not been well documented
or advertised; they existed primarily to serve GUD, Incline, and KPIs.
@jklukas jklukas force-pushed the generic-glean-usage branch from fd1103a to e36c3be Compare April 10, 2020 13:14
Copy link
Contributor

@fbertsch fbertsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A few questions:

  1. How have you confirmed that no one is using the metrics derived fields?
  2. Will we need to backfill with these schema-incompatible changes?

@jklukas
Copy link
Contributor Author

jklukas commented Apr 13, 2020

1. How have you confirmed that no one is using the metrics derived fields?

I don't have proof of this, but I will send out an announcement with at least a few days for folks to report uses before I merge this and delete things.

2. Will we need to backfill with these schema-incompatible changes?

The generic glean ETL is all new tables baseline_clients_daily and baseline_clients_last_seen. We are simply deleting tables here, not altering any schemas.

@jklukas
Copy link
Contributor Author

jklukas commented May 8, 2020

This was done in #925 instead.

@jklukas jklukas closed this May 8, 2020
@jklukas jklukas deleted the generic-glean-usage branch July 7, 2020 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants