Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give Census access to country codes table #6267

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

kwindau
Copy link
Contributor

@kwindau kwindau commented Sep 26, 2024

Description

This PR is to grant the table moz-fx-data-shared-prod.static.country_codes_v1 permission to be read by our Census data feed tool.

Reviewer, please follow this checklist

┆Issue is synchronized with this Jira Task

@dataops-ci-bot
Copy link

Integration report for "Give Census access to country codes table"

sql.diff

Click to expand!
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/static/country_codes_v1/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/static/country_codes_v1/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/static/country_codes_v1/metadata.yaml	2024-09-26 19:12:11.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/static/country_codes_v1/metadata.yaml	2024-09-26 19:10:18.000000000 +0000
@@ -4,11 +4,7 @@
 
   Includes XK/XKK for Kosovo, which is not in the ISO 3166 standard, but is recognized
   by some governing bodies and is present in MaxMind's GeoIP2 database.
-owners: []
-labels: {}
-bigquery: null
 workgroup_access:
 - role: roles/bigquery.dataViewer
   members:
-  - workgroup:mozilla-confidential
-references: {}
+  - workgroup:dataops-managed/external-census

Link to full diff

@@ -4,3 +4,7 @@ description: |

Includes XK/XKK for Kosovo, which is not in the ISO 3166 standard, but is recognized
by some governing bodies and is present in MaxMind's GeoIP2 database.
workgroup_access:
Copy link
Member

@whd whd Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something to watch out for is #5830 but since static is a special case dataset and we're unlikely to deprecate anything there this should propagate without issue.

@fbertsch fbertsch added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit ed660c1 Sep 26, 2024
21 checks passed
@fbertsch fbertsch deleted the update-permissions branch September 26, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants