Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center wordmarks on mobile (fixes #10666) #10874

Conversation

maureenlholland
Copy link
Collaborator

Description

Center wordmarks for Contentful homepage hero components. A stop-gap fix until we resolve the underlying Protocol issue: mozilla/protocol#718

The Hero component has mobile centering for logos only. We added the wordmark for Contentful Hero but since the Protocol component is deprecated, we won't be updating Hero in Protocol. It's a Mozilla only fix because we should not be using the Contentful Hero component on new pages.

Issue / Bugzilla link

#10666

Testing

http://localhost:8000/en-US/

At mobile view size, Hero wordmarks in the Featured Mozilla Products section should be centered.
Above that view size, the wordmarks should be left-aligned or right-aligned (depending on dir attribute)

@maureenlholland maureenlholland added Bug 🐛 Something's not working the way it should Contentful Needs Review Awaiting code review Review: µ Code review time: 5 minutes or less labels Dec 6, 2021
@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #10874 (970da65) into master (710e75f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10874   +/-   ##
=======================================
  Coverage   74.37%   74.37%           
=======================================
  Files         139      139           
  Lines        7079     7079           
=======================================
  Hits         5265     5265           
  Misses       1814     1814           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 710e75f...970da65. Read the comment docs.

Copy link
Member

@alexgibson alexgibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big improvement on mobile 💯 r+

@alexgibson alexgibson merged commit 4b4c4f6 into mozilla:master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 Something's not working the way it should Needs Review Awaiting code review Review: µ Code review time: 5 minutes or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants