This repository has been archived by the owner on Sep 2, 2020. It is now read-only.
Routes for adding single badges to milestone, removing single badges. #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 /cc @SueSmith can you update the docs to add this new route? |
cmcavoy
added a commit
that referenced
this pull request
Jun 13, 2014
Routes for adding single badges to milestone, removing single badges.
|
@cmcavoy sure, have still to add milestone badge auto-awarding info as well.. will do here https://github.com/mozilla/badgekit-api/tree/doc-tidy |
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
/system/:systemSlug/milestones/:milestoneId/add-badgeand.../remove-badgeto be able to add and remove single badges from a milestone without affecting the rest of the support badges.This also implements a milestone finder middleware, which handles
ResourceNotFounderrors more gracefully.@cmcavoy, @christensenep to review.