This repository has been archived by the owner on Sep 2, 2020. It is now read-only.
HTTP connection hangs when trying to create a duplicate badge instance #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm able to issue badge instances by using
POST /systems/:slug/badges/:slug/instances. However, if I try to issue a second badge to the same e-mail address, the server does not behave properly. It should give me back an HTTP409 Conflict, as in the "Duplicate entry" error message in this other endpoint. Instead, it either closes the connection or leaves it hanging, I can't tell.The pull request here is obviously not a solution, it just points out where the error-handling logic could go. It does cause the HTTP connection to terminate correctly, so my client library doesn't hang forever waiting for a response.