Badge types #64
Badge types #64
Conversation
|
hey @daytonn the 'types' are established, there's only four. The badgetype doesn't need to be it's own table, it can just be an enum. @christensenep has details. |
|
Oh, ok, there's an interface in the issue that shows admin's having CRUD ability on types BTW @pushcx says hi (he's pairing with me today) |
| @@ -7,7 +7,7 @@ const makeValidator = validation.makeValidator; | |||
| const optional = validation.optional; | |||
| const required = validation.required; | |||
|
|
|||
| const Criteria = require('./criteria') | |||
| const Criteria = require('./criteria'); | |||
There was a problem hiding this comment.
So the errors you're getting during testing are actually because nothing is ever actually requiring the ./badge-type model during those tests, so the badge model gets confused because it has a relationship to a 'badgeTypes' table that never gets defined. Adding a
require('./badge-type');
line here will fix that.
There was a problem hiding this comment.
Ah yes, it had to be something stupid. I'm spoiled by rails. Make a model, voila it's available ;)
WIP getting some errors testing that I'm not sure how to address. Also cleaned up some semi-colons (I'm a lint guy).