Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit for use of CTAP2 canonical CBOR encoding #225

Open
jschanck opened this issue Feb 17, 2023 · 0 comments · May be fixed by #328
Open

Audit for use of CTAP2 canonical CBOR encoding #225

jschanck opened this issue Feb 17, 2023 · 0 comments · May be fixed by #328

Comments

@jschanck
Copy link
Collaborator

We need to review our serialization routines to ensure that we use CTAP2 canonical CBOR encoding form. Martin Kreichgauer noticed that the keys in our AttestationObjects maps are in the order (authData, fmt, attStmt) instead of the correct (fmt, attStmt, authData). I'll fix that issue, but we should do an audit and add tests as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tests to check that all CBOR requests are in canonicalized form EliasHolzmann/authenticator-rs
1 participant
@jschanck