Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax hold criteria, to promoted add-ons in groups but not approved yet #22941

Conversation

eviljeff
Copy link
Member

@eviljeff eviljeff commented Dec 12, 2024

Fixes: mozilla/addons#15244

Description

Changes should_hold_action criteria in actions to include promoted groups where the add-on is not yet approved for that promotional group

Testing

A pain to fully test, but:

  • add an add-on to a promoted* group locally, but don't approve the add-on for that promoted group. (can be verified with an api response - the promoted group shouldn't be included; or listing page on frontend shouldn't badge the group)
  • report add-on to Cinder
  • process that report in Cinder with a policy that would disable the add-on
  • replay the webhook response locally
  • see the add-on isn't disabled
  • see the add-on in the 2nd level approvals queue in reviewer tools
  • (optionally repeat with a Rating developer reply on a promoted** add-on, or a user profile that's an owner of a promoted** add-on)

*recommended, line, spotlight notable
**recommended, line

Checklist

  • Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
  • Successfully verified the change locally.
  • The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.
  • Add before and after screenshots (Only for changes that impact the UI).
  • Add or update relevant docs reflecting the changes made.

@eviljeff eviljeff requested a review from diox December 12, 2024 13:51
@eviljeff eviljeff merged commit ee87129 into mozilla:master Dec 12, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Include all promoted add-ons in second level approval, regardless of last review date
2 participants