Don't show duplicate flags for NeedsHumanReview reasons already flagged explicitly #22900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed explicitly Those new NeedsHumanReview reasons get a flag because they are in VIEW_QUEUE_FLAGS. That is useful for the form to filter the queue for those reasons, but they don't need to show the corresponding sprite icon, because we also already display one by checking AddonReviewerFlags/PromotedAddon state.
eviljeff
approved these changes
Nov 28, 2024
|
Yeah I think the proper fix would be to make the form depend on something else than I'll file a follow-up |
1 task
diox
added a commit
that referenced
this pull request
Nov 28, 2024
…ed explicitly (#22900) Those new NeedsHumanReview reasons get a flag because they are in VIEW_QUEUE_FLAGS. That is useful for the form to filter the queue for those reasons, but they don't need to show the corresponding sprite icon, because we also already display one by checking AddonReviewerFlags/PromotedAddon state.
chrstinalin
pushed a commit
that referenced
this pull request
Jan 10, 2025
…ed explicitly (#22900) Those new NeedsHumanReview reasons get a flag because they are in VIEW_QUEUE_FLAGS. That is useful for the form to filter the queue for those reasons, but they don't need to show the corresponding sprite icon, because we also already display one by checking AddonReviewerFlags/PromotedAddon state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those new
NeedsHumanReviewreasons get a flag because they are inVIEW_QUEUE_FLAGS. That is useful for the form to filter the queue for those reasons, but they don't need to show the corresponding sprite icon, because we also already display one by checkingAddonReviewerFlags/PromotedAddonstate.Fixes: mozilla/addons#15072 (see screenshots posted by QA)