Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display block type in reviewer tools & Use specific activity log for soft-blocking versions #22891

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

diox
Copy link
Member

@diox diox commented Nov 25, 2024

Fixes: mozilla/addons#15125

Testing

Add some hard and soft-blocks / harden some soft-blocks / soften some hard-blocks: this should be reflected in reviewer tools review page next to the corresponding version in the history. (For accurate soft-block info, the block need to have been created as soft or softened after applying this patch)

Screenshots

Version soft-blocked:
Screenshot 2024-11-25 at 13-55-45 rabbil-rabugong-narkato – Add-ons for Firefox

Version soft-blocked then hardened:
Screenshot 2024-11-25 at 14-23-01 rabbil-rabugong-narkato – Add-ons for Firefox

@diox diox marked this pull request as ready for review November 25, 2024 14:54
@diox diox requested review from a team and KevinMind and removed request for a team November 25, 2024 14:54
@diox diox requested a review from KevinMind November 26, 2024 21:06
@KevinMind
Copy link
Contributor

Soft -> Hard -> Soft

image

Hard -> Soft -> Hard -> Unblocked

image

Copy link
Contributor

@KevinMind KevinMind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works.

@diox diox merged commit 5684a01 into mozilla:master Nov 27, 2024
31 checks passed
KevinMind pushed a commit that referenced this pull request Nov 27, 2024
…soft-blocking versions (#22891)

* Display block type in reviewer tools & Use specific activity log for soft-blocking versions
chrstinalin pushed a commit that referenced this pull request Jan 10, 2025
…soft-blocking versions (#22891)

* Display block type in reviewer tools & Use specific activity log for soft-blocking versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Add-on history should display whether a version is restricted or blocked
2 participants