Refactor MLBF in preparation for soft blocking #22718
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: mozilla/addons#15014
Description
by_block_type
queryset onBlockVerssion
model to query blocked versions by block type consistently.BlockType
enum to model block type consistently.MLBF_File
to model the additional mlbf files "stash" "notblocked"MLBF
from storage (with improvedpath
helper) based on MLBF_File inputContext
This PR should introduce zero changes to the public API of
MLBF
or the functionality but sets the stage for adding additional block types for deriving filters/stashes per type.The current implementation is really designed for a binary blocked/unlblocked but we will now need 2 binary states and we can reduce some boilerplate and introduce the concepts for doing that in a PR that doesn't actually require changing the API, reducing the size of the PR introducing soft blocking.
Testing
CI passes.
Checklist
#ISSUENUM
at the top of your PR to an existing open issue in the mozilla/addons repository.