Add clean_docker command and fix local build_docker_image when run with empty cache #22050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinMind
changed the title
diox
reviewed
Mar 21, 2024
diox
approved these changes
Mar 21, 2024
KevinMind
force-pushed
the
fix-local-build-docker-cacheless
branch
from
168e1a2 to
f591615
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: mozilla/addons#1992, PR #22044
Description
This PR achieves 2 aims.
Add a
clean_dockercommand to enable pristine builds by removing local cache directories that can be "incorrectly" mounted to the build context causing unexpected issues. (see linked PR)fix local docker build errors when there is no cache directory present. (first build or pristine build)
Fix local
build_docker_imagecommand when there is a purged cache.Only include the
---cache-fromargument todocker buildwhen the index.json for a previous docker build cache exists. if it doesn't exist and you pull as a cache it can lead to docker build errors.