Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #2 Training classification model for winequality.csv dataset #92

Merged
merged 5 commits into from
Mar 27, 2020
Merged

issue #2 Training classification model for winequality.csv dataset #92

merged 5 commits into from
Mar 27, 2020

Conversation

msmelo
Copy link
Contributor

@msmelo msmelo commented Mar 20, 2020

No description provided.

Copy link
Contributor

@mlopatka mlopatka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR. It looks like your first contribution to the PRESC project!
Overall, it is a good start to the classification task. I do have some changes to recommend:

  • Please use the dataset that is already provided in the repo, when you load it use a relative path that reflects the directory structure of the repository so that other people can run your code locally without errors.
  • The relationship between quality and recommend is completely separable, I.e. the quality is a perfect predictor of whether or not it is recommended. 100% accuracy is always suspicious :)
  • Please repeat the analysis dropping quality from the features.
  • The confusion matrices for every classifier considered are not adding important information. Please summarize the interesting findings of this analysis in light of different classifier performance.

@msmelo
Copy link
Contributor Author

msmelo commented Mar 23, 2020

Hello @mlopatka
Thanks for the feedback! I've made some changes and I've deleted the csv file from the folder. I struggled a little bit to commit the changes, but I believe the file is updated now.

@mlopatka mlopatka merged commit 5dc5a98 into mozilla:master Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants