-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Train test ratio #43
Train test ratio #43
Conversation
Multi-line comments will be replaced with docstrings, following the recommendations of the maintainer concerning pull request 28, and according to PEP conventions. |
The principal commit is "Effect of split ratio on performance"(sha 599990c). It shows the progressive changes that have been made to address this particular issue #3. |
@dzeber @mlopatka Should I continue in this way? that is, reusing the modules I created in the previous pull request for the next?. This will therefore necessitate that the branch of the next pull request will be 'branched out' from this one in order to make these modules available for reuse as I did here. |
@mlopatka please can you merge this? I do not have merging rights. |
@tab1tha apologies for the delay. |
@mlopatka I have resolved all the merge conflicts but one. I resolved locally and when I pushed the changes there is one conflict that is present her in k_nn.py |
@tab1tha can you verify that knn.py looks good to you? |
This pull request addresses #3
The vehicles.csv dataset is used instead of the generated.csv dataset so that variation could easily be observed. It plots a graph of accuracy against test size and yields a table containing progressive values of performance indices (precision, f1_score, recall), as the test size is changed.
This commit uses modules created in #28 and so it incorporates those changes since the said pull request has not yet been merged to Upstream/master.
The main file here is train_test_ratio.py which imports the load_dataset and test_size vary modules.
The k_nn module created in the aforementioned issue is modified slightly and imported as part of this solution. The train_test_ratio.ipynb file shows the results obtained by implementing the changes in this pull request.