Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for #6 : Visualise evaluation metric #27

Merged
merged 5 commits into from
Mar 24, 2020

Conversation

KaairaGupta
Copy link
Contributor

@KaairaGupta KaairaGupta commented Mar 8, 2020

For #6
The task was to plot the mean and spread of y vs x.
I have plotted the following vs x with input as defined in the task:

  • mean of y
  • maximum and minimum values of y
  • spread of y around mean (standard-deviation)

@KaairaGupta KaairaGupta changed the title Visualise evaluation metric for #6 : Visualise evaluation metric Mar 8, 2020
Copy link
Contributor

@dzeber dzeber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is nice, clean and concise, and the plot looks good. Rather than introducing the standard deviation band, I think it is sufficient to have the band running between the min and the max. As the data would typically come from computing a metric over repeated runs, the spread of the y-values in the table themselves represent the variability of the metric. In that case, the legend would no longer be necessary.

"\n",
"# Creating simple data for [x1,x2,x3,...x4]\n",
"for i in range(10):\n",
" x.append(i)\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, np.arange(10)

@KaairaGupta
Copy link
Contributor Author

@dzeber Do you want me to remove the standard deviation band and just show a band between min and max y?
Also, I was thinking to plot multiple graphs, one as above and other with violin plots. Do you think I should add that?

@mlopatka
Copy link
Contributor

mlopatka commented Mar 16, 2020

@KaairaGupta I'll jump in for @dzeber here since he is away until Wednesday.

@dzeber Do you want me to remove the standard deviation band and just show a band between min and max y?

Yes, you should update the visualization to include only the min/max bounds.

Also, I was thinking to plot multiple graphs, one as above and other with violin plots. Do you think I should add that?

Yes! I think violin plots would be very informative in complimenting the above-mentioned plot.

@KaairaGupta
Copy link
Contributor Author

KaairaGupta commented Mar 18, 2020

@dzeber @mlopatka
I have made all required changes. PTAL.

Example here.

@mlopatka mlopatka merged commit b882029 into mozilla:master Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants