Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

general train-test split and k-fold evaluation #158

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

asthad16
Copy link
Contributor

@asthad16 asthad16 commented Apr 5, 2020

though the initial PR made were successfully merged but they were not general for any model. now i have generalized them and also added
another variant of k-fold cross validation (LOOCV) for improved results.

though the initial PR made were successfully merged but they were not general for any model. now i have generalized them and also added
another variant of k-fold cross validation (LOOCV) for improved results.
@asthad16
Copy link
Contributor Author

asthad16 commented Apr 5, 2020

@dzeber u suggested me to implement leave one out CV and also my function was not generalized for any model for #3 and #4 issues but now i have fixed this.

@asthad16
Copy link
Contributor Author

asthad16 commented Apr 5, 2020

please do consider #158 and review it.

@dzeber dzeber merged commit 6be4345 into mozilla:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants