Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade PyFxA and add tests to confirm that fxa-generation fields are correctly handled. #182

Closed
tublitzed opened this issue Apr 29, 2020 · 1 comment
Assignees

Comments

@tublitzed
Copy link
Contributor

tublitzed commented Apr 29, 2020

Once this issue is done, we can jump into the changes we need to make here in the tokenserver.

To support the larger efforts to get the FxA Rust Component into Desktop, we first need to get Sync completely migrated away from BrowserID over to OAuth.

@rfk
Copy link
Contributor

rfk commented Jun 10, 2020

Re: "confirm that generation fields are correctly handled", we need to add a bit of logic so that if the OAuth verifier returns a generation field, then it gets reflected as fxa-generation in the idpClaims dict here:

And add a corresponding test in this file:

The value of fxa-generation should be an int, not a string.

For completeness we could also consider updating the mock verifier in the service tests to sometimes return a generation number, but I don't know how much churn that would induce:

fzzzy added a commit that referenced this issue Jun 11, 2020
…sponse; add a test to cover using the 'generation' field.
@fzzzy fzzzy closed this as completed in 51ddd89 Jun 11, 2020
fzzzy added a commit that referenced this issue Jun 11, 2020
Fix #182: Update PyFxA and handle 'generation' fields in the oauth re…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants