Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust routing logic for new users to allow us to point X% of them to Spanner. #159

Closed
tublitzed opened this issue Nov 22, 2019 · 7 comments · Fixed by #163
Closed

Adjust routing logic for new users to allow us to point X% of them to Spanner. #159

tublitzed opened this issue Nov 22, 2019 · 7 comments · Fixed by #163
Assignees
Labels
3 Estimate - m - This is a small change, but there's some uncertainty.

Comments

@tublitzed
Copy link
Contributor

We're planning to rollout Durable Sync for brand new users of Sync only to start with. Before we can move to phase 2, we'll need to adjust the logic here to make it easy to route users by a percentage.

Ideally, that percentage can be pulled from a config value somewhere so we can easily modify it without a deploy.

Once a user has been routed to Spanner, we'll need to continue routing them over to Spanner for subsequent sessions.

It looks like the logic for routing a new user lives here for reference.

@tublitzed tublitzed added the 3 Estimate - m - This is a small change, but there's some uncertainty. label Nov 22, 2019
@tublitzed tublitzed assigned pjenvey and unassigned pjenvey Dec 4, 2019
@tublitzed
Copy link
Contributor Author

This is going to Donovan once we get him access to this repo.

@fzzzy
Copy link
Contributor

fzzzy commented Dec 4, 2019

@rfk can you give me permissions for this repo and assign this to me?

@rfk
Copy link
Contributor

rfk commented Dec 5, 2019

Somehow I can't, I think I've lost my admin rights to this repo :-(

I'll see if I can track down someone who does.

@rfk
Copy link
Contributor

rfk commented Dec 5, 2019

We may need to ask @tblow for help with admin settings here; ideally we wind up with:

  • @fzzzy and @jrconlin added to the sync-devs team
  • At least one member of the sync-devs team promoted to maintainer status for said team, so we can manage that ourselves in future

@rfk
Copy link
Contributor

rfk commented Dec 5, 2019

The above has made its way into the correct place for actioning such requests (which for future reference, is as an issue in https://github.com/mozilla-services/github-management/) and I'll update here once it's complete.

@rfk
Copy link
Contributor

rfk commented Dec 9, 2019

@fzzzy you should now have access to the repo; let me know if something isn't working as expect.

@rfk rfk assigned fzzzy Dec 9, 2019
@fzzzy
Copy link
Contributor

fzzzy commented Dec 9, 2019

Seems to be working, thanks!

@tublitzed tublitzed assigned jrconlin and unassigned fzzzy Dec 16, 2019
jrconlin added a commit that referenced this issue Dec 19, 2019
This adds a few entries into the .ini:

```
[tokenserver]
spanner_entry  = # Name of the spanner node name e.g.  https://spanner.example.com
spanner_node_id = # default spanner node id
migrate_new_user_percentage = # percentage of users to send to spanner

```
*note* the "percentage" is a terrible hack that just sends the first _n_
of every 100 users to spanner.

Closes #159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 Estimate - m - This is a small change, but there's some uncertainty.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants