refactor: remove duplicate code for incrementing counters #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56quarters
changed the title
jrconlin
requested changes
Jan 26, 2021
jrconlin
previously approved these changes
Jan 26, 2021
|
Working on fixing commit signing. Sorry about that. |
|
Sigh... My apologies, but could you either rebase this PR to a signed commit or resubmit with all the commits signed? If this is too annoying, let me know and I'll resubmit for you, (with appropriate credit). Sorry for the hassle. |
|
Oh, man, NO NEED to apologize for us making things harder.
Seriously, thank you for taking the time to submit a PR. It means a lot.
…On Tue, Jan 26, 2021 at 9:12 AM Nick Pillitteri ***@***.***> wrote:
@56quarters <https://github.com/56quarters> requested your review on: #981
<#981> refactor:
remove duplicate code for incrementing counters.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#981 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAIXK6F54SVCMXHE6AFQSLS33ZZBANCNFSM4WSXJVAA>
.
|
Delegate to count method and use glob import for metric traits
jrconlin
approved these changes
Jan 26, 2021
jrconlin
added a commit
that referenced
this pull request
Jan 26, 2021
From @56quarters in #981 Delegate to count method and use glob import for metric traits (resubmitting due to github commit signature issues -- jrc)
|
@56quarters Just in case you don't want to deal with github being annoying, I resubmitted your patch in #983. Feel free to review, comment, and point out what I may have gotten wrong. |
|
Closed in favor of #983 |
jrconlin
added a commit
that referenced
this pull request
Jan 27, 2021
From @56quarters in #981 Delegate to count method and use glob import for metric traits (resubmitting due to github commit signature issues -- jrc)
jrconlin
added a commit
that referenced
this pull request
Jan 27, 2021
From @56quarters in #981 Delegate to count method and use glob import for metric traits (resubmitting due to github commit signature issues -- jrc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delegate to count method and use glob import for metric traits