Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #900

Merged
merged 3 commits into from
Nov 4, 2020
Merged

chore: update dependencies #900

merged 3 commits into from
Nov 4, 2020

Conversation

jrconlin
Copy link
Member

@jrconlin jrconlin commented Nov 3, 2020

Description

  • cargo audit flagged a deep dependency,
  • which required updating libraries
  • which broke a few tests due to formatting
  • which also required a few function changes due to obsolete

Testing

do CI tests pass and does the tree go green?
👍 👍

Issue(s)

* cargo audit flagged a deep dependency,
* which required updating libraries
* which broke a few tests due to formatting
* which also required a few function changes due to obsolete
@jrconlin jrconlin requested a review from a team November 3, 2020 00:14
* lib updates
* fixed "-1"
* e2e probably still broke.
Copy link
Contributor

@fzzzy fzzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping on this grenade.

@fzzzy fzzzy merged commit 0afb969 into master Nov 4, 2020
@fzzzy fzzzy deleted the chore/fix-tests branch November 4, 2020 14:07
@jrconlin
Copy link
Member Author

jrconlin commented Nov 4, 2020

heh, I was going to add the correct issue. (I filed #901 yesterday) Will manually close that one.

@pjenvey pjenvey mentioned this pull request Nov 4, 2020
jrconlin added a commit that referenced this pull request Nov 4, 2020
Keeping grpcio at 0.6 for the time being due to several breaking changes
This PR is in concert with #900

Closes #899, #902
jrconlin added a commit that referenced this pull request Nov 4, 2020
* this is companion to #900
* Keeping grpcio at "0.6" due to a few breaking changes

Closes #899
jrconlin added a commit that referenced this pull request Nov 5, 2020
* this is companion to #900
* Keeping grpcio at "0.6" due to a few breaking changes

Closes #899
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants