chore: Update circleci to use docker auth #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto chore/dockerflow_update
Micheletto
approved these changes
Oct 12, 2020
There was a problem hiding this comment.
From my understanding, this should work. If you wanted to avoid multiple docker login commands boiler plate, you could do something like this. But, I would leave this as is.
|
Oh, thanks! Didn't know about that. I'll definitely include that in the update for the other packages. |
…nto chore/dockerflow_update
This was referenced Oct 12, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding authorization per steps outlined in https://github.com/mozilla-services/Dockerflow/pull/58/files
Testing
Should pass CircleCI.
Issue(s)
Closes #854