feat: switch spanner's db pool to deadpool #798

pjenvey · 2020-08-21T23:59:49Z

Description

this is a quick integration of deadpool to be revisited with some more cleanup

All current tests pass and to be load tested against stage

Issue #794

this is a quick integration of deadpool to be revisited with some more cleanup Issue #794

jrconlin

Huh, the deadpool version feels a bit cleaner since you're not passing around a '_ lifetime.

you've got a couple of stray //XXX tags that might need to be cleaned up or commented.

src/db/spanner/manager/bb8.rs

pjenvey added 2 commits August 21, 2020 16:56

refactor: cleanup/rearrange

7e526cb

feat: switch spanner's db pool to deadpool

077bf09

this is a quick integration of deadpool to be revisited with some more cleanup Issue #794

pjenvey requested a review from a team August 21, 2020 23:59

jrconlin previously approved these changes Aug 22, 2020

View reviewed changes

src/db/spanner/manager/bb8.rs Outdated Show resolved Hide resolved

f kill dev comments

a9da154

pjenvey dismissed jrconlin’s stale review via a9da154 August 22, 2020 00:14

jrconlin approved these changes Aug 22, 2020

View reviewed changes

pjenvey merged commit 0a2fecc into master Aug 22, 2020

pjenvey deleted the feat/796 branch August 22, 2020 01:07