feat: Backport debug_client opt
#781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
includes latest rust clippy fixes and a sentry bump related to build issues Co-authored-by: JR Conlin <[email protected]> Closes #779
Closed
jrconlin
approved these changes
Aug 12, 2020
AzureMarker
reviewed
Aug 13, 2020
| @@ -224,6 +224,26 @@ impl FromRequest for BsoBodies { | |||
| )); | |||
| } | |||
| }; | |||
|
|
|||
| // ### debug_client | |||
| if let Some(uids) = &state.limits.debug_clients { | |||
There was a problem hiding this comment.
This is duplicated below and should be moved to a function, assuming the code will exist for more than a trivial amount of time.
There was a problem hiding this comment.
Yep. Fortunately, this hack is just to test to see if production mobile clients behave correctly when an OverQuota response is returned, and will be dropped shortly afterward.
It's the reason that the patch also has a really crappy "--debug_client" "--debug_clients" pair of options. That's horribly confusing and should never be allowed (except if it's part of some crappy hack to test clients that can't hit stage)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
includes latest rust clippy fixes and a sentry bump related to build issues
Co-authored-by: JR Conlin [email protected]
Testing
Should work just like the current prod version.
Issue(s)
Closes #779