feat: add --user_percent option
#561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrconlin
added
🚧WIP
The `--user_percent` option will divvy up the users into blocks and move the specified block. It takes an option formatted as "block#:percentage". Block numbers are 1 based. For example, --user_percent=2:33 will divide the total distinct users into non-overlapping blocks of approximately 33%, and then move the second block (e.g. the 33-65th users in the list). Extra users that may not be evenly divided into percentage blocks will be appended to the last block. (e.g. for `--user_percent=3:33`, users 66-99 would be copied over, a total of 34 users) Issue #407
use `ms_delay` to pause between spanner transaction `--readchunk`s. This allows some primative throttling for feeding spanner data. Reminder: `readchunk` sets the max number of items to try to write per chunk to spanner in any given transaction, default value 1000.
jrconlin
force-pushed
the
user_migration3
branch
from
adf5df6
to
55edc74
Compare
pjenvey
requested changes
Apr 2, 2020
…rage-rs into user_migration3
pjenvey
previously approved these changes
Apr 6, 2020
…rage-rs into user_migration3
…running from automation
* add eolson's fix for collections sql
…rage-rs into user_migration3
* check for "NULL" client_state in user.csv and skip if need be.
add success / fail uid files.
…nto user_migration3
pjenvey
previously approved these changes
Apr 8, 2020
TLDR: Don't use a single %
…rage-rs into user_migration3
pjenvey
approved these changes
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the following flags:
--user_percentwill divvy up the users into blocks and move the specified block. It takes an option formatted as "block#:percentage". Block numbers are 1 based. For example,--user_percent=2:33will divide the total distinct users into non-overlapping blocks of approximately 33%, and then move the second block (e.g. the 33-65th users in the list). Extra users that may not be evenly divided into percentage blocks will be appended to the last block. (e.g. for--user_percent=3:33, users 66-99 would be copied over, a total of 34 users)--ms_delaywill pause this many milliseconds between spanner transaction writes (default 0). Each spanner transaction contains--write_chunkrows (1000). note: this is a rename of the unused--readchunkoption)Testing
local testing can be used to determine that users are divided up into groups properly.
--dryrunshould help by preventing data from being actually written to spanner.Issue(s)
Issue #407 #571