-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: more user_migration stuff #450
Conversation
* create script to move users by node directly * moved old scripts to `old` directory (for historic reasons, as well as possible future use) * cleaned up README
* try to solve the `parent row` error intermittent error may be responsible from one of two things: 1) a transaction failure resulted in a premature add of the unique key to the UC filter. 2) an internal spanner update error resulting from trying to write the bso before the user_collection row was written.
* Added "fix_collections.sql" script to update collections table to add well known collections for future rectification. * returned collection name lookup
using this branch to track changes to the scripts used for migration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good, just a few comments.
```bash | ||
GOOGLE_APPLICATION_CREDENTIALS=credentials.json migrate_node.py \ | ||
[--dsns=move_dsns.lst] \ | ||
[--deanon --fxa_file=users.csv] \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean if you pass the deanon switch you have to pass the fxa-file switch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. I decided not to automatically enable fxa-file
as a safeguard.
It's the "are you sure" approach to copying user data.
…nto user_migration2
Description
old
directory (for historic reasons, as well as possible future use)Testing
These are operational scripts. If desired, you can test using the stage: sync_migration_test spanner instance.
Issue(s)
Issue: #407