-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: filter out variable data from URI metric #421
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I don't think it's terribly important for uri.path to be a sentry tag. It could be sent as an "extra" instead, which isn't indexed. A similar argument could probably be made for other tags we currently send. If we want to keep it as a tag we'd probably want to further parse the query parameters so they're sorted (so ?batch=#&commit=true aren't differentiated from ?commit=true&batch=#) |
@@ -95,8 +94,6 @@ where | |||
tags.tags.insert(k, v); | |||
} | |||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's continue sending it to Sentry but in its extras for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly, the lib we're using doesn't understand how to send "extras", only "tags".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I might be confusing this with the cadence library. Sorry. That kind of morning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+ pending the clippy warning (not sure what happened there).
Description
filter out UID and batch numbers from URI.
This drops the first two path elements from the URI as well as masks any large hexidecimal identifier that may appear in the URI parameters. This should retain enough diagnostic information to be useful without causing overload for sentry.
Testing
While running normal testing note that the
uri.path
metric goes from something like:/1.5/135772380/storage/history?batch=5ef59eae10244edc90935bab2ffea0f0&commit=true
to
storage/history?batch=###&commit=true
Issue(s)
Closes #420