Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: cleanup spanner's schema #247

Merged
merged 1 commit into from
Oct 4, 2019
Merged

refactor: cleanup spanner's schema #247

merged 1 commit into from
Oct 4, 2019
+185 −178

Conversation

pjenvey
Copy link
Member

@pjenvey pjenvey commented Oct 4, 2019

needs #246 merged first

it's deployed on the sync_schema database

@pjenvey pjenvey requested review from jrconlin and fzzzy October 4, 2019 21:25
@pjenvey pjenvey changed the title Refactor/schema refactor: cleanup spanner's schema Oct 4, 2019
jrconlin
jrconlin previously approved these changes Oct 4, 2019
View reviewed changes
@jrconlin
Copy link
Member

jrconlin commented Oct 4, 2019

I do kinda wish that fxa_uid and fxa_kid weren't just one buried letter off, but that's not really something we can change.

@pjenvey
Copy link
Member Author

pjenvey commented Oct 4, 2019

I do kinda wish that fxa_uid and fxa_kid weren't just one buried letter off, but that's not really something we can change.

Agreed, it's uid in fxa's db table, kid in its scoped keys, and thus everywhere else

@pjenvey pjenvey merged commit e35716a into master Oct 4, 2019
@pjenvey pjenvey deleted the refactor/schema branch October 4, 2019 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrconlin jrconlin jrconlin approved these changes

@fzzzy fzzzy Awaiting requested review from fzzzy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjenvey @jrconlin