Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/170 #237

Merged
merged 14 commits into from
Oct 3, 2019
Merged

Fix/170 #237

merged 14 commits into from
Oct 3, 2019

Conversation

jrconlin
Copy link
Member

@jrconlin jrconlin commented Sep 30, 2019 •
edited
Loading

  • Added "kid" column to database:
  • May want to use alternate "sync_kid" db for local testing
    DSN: spanner://projects/sync-spanner-dev-225401/instances/spanner-test/databases/sync_kid
  • Switched over indexing to use "fxa_id" (kid) and pass HawkParameter when possible.

Issue #170

pjenvey and others added 6 commits September 27, 2019 09:46
@pjenvey
wip
4a9a46a
@pjenvey
more
00ceea5
@jrconlin
Merge branch 'master' of github.com:mozilla-services/syncstorage-rs i…
6adffb2 
…nto fix/170
@jrconlin
f Add "kid" column to database
64a1f53 
* May want to use alternate "sync_kid" db.
  DSN: spanner://projects/sync-spanner-dev-225401/instances/spanner-test/databases/sync_kid
* switched over index to use "fxa_id" (kid), and pass HawkParameter when possible

Issue #170
@jrconlin
Merge branch 'master' of github.com:mozilla-services/syncstorage-rs i…
e4a63dd 
…nto fix/170
@jrconlin
Merge branch 'master' of github.com:mozilla-services/syncstorage-rs i…
e5de70c 
…nto fix/170
@jrconlin jrconlin requested review from pjenvey and fzzzy September 30, 2019 19:46
@jrconlin
Copy link
Member Author

I'm fine rebasing this into one PR. There were a few messier merges in play, but not sure if we want to lose history.

pjenvey
pjenvey requested changes Oct 1, 2019
View reviewed changes
src/server/test.rs Outdated Show resolved Hide resolved
src/web/auth.rs Outdated Show resolved Hide resolved
@jrconlin
f r's
adb463f 
* Added ddl for spanner
* include old index and new index entries
* change to fxa_kid to reduce confusion
* match tombstone behaviors between mysql & spanner

Closes #170
@jrconlin jrconlin requested a review from pjenvey October 2, 2019 17:45
pjenvey
pjenvey requested changes Oct 2, 2019
View reviewed changes
src/web/extractors.rs Outdated Show resolved Hide resolved
src/db/spanner/models.rs Outdated Show resolved Hide resolved
src/db/spanner/models.rs Outdated Show resolved Hide resolved
src/db/spanner/models.rs Outdated Show resolved Hide resolved
@jrconlin jrconlin requested a review from pjenvey October 3, 2019 00:51
@jrconlin jrconlin merged commit 11b4b07 into master Oct 3, 2019
@jrconlin jrconlin deleted the fix/170 branch October 3, 2019 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjenvey pjenvey pjenvey approved these changes

@fzzzy fzzzy Awaiting requested review from fzzzy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrconlin @pjenvey