feat: move context of glean metrics into statsd get_collections metric #1638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjenvey
approved these changes
Dec 4, 2024
jrconlin
approved these changes
Dec 4, 2024
jrconlin
deleted the
feat/move-glean-emission-alongside-statsd-SYNC-4548
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We should ideally emit the glean metrics alongside in the typical place we emit statsd metrics: after acquiring a db connection.
In the face of errors on acquiring db connections (which aren’t totally uncommon, we’re currently having spikes of them) we would emit a few less events that are likely going to be duplicates of clients later retrys anyway. The other benefit (in the case of errors) is our glean events should more closely correlate to our actual statsd metrics.
Moves everything into the
transaction_httpblock, so Glean flag can still toggle.Testing
Issue(s)
Closes SYNC-4548.