fix: upgrade to latest deadpool #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjenvey
force-pushed
the
fix/upgrade-deadpool-SYNC-4522
branch
2 times, most recently
from
a6c3bfd to
322a6eb
Compare
jrconlin
previously approved these changes
Nov 21, 2024
|
Sigh, yeah, we might want to back-burner this for a while. Looks like there's a number of significant changes in the main version. |
pjenvey
force-pushed
the
fix/upgrade-deadpool-SYNC-4522
branch
from
322a6eb to
cb16b97
Compare
which includes a fix for its incorrect metrics: bikeshedder/deadpool#92 Closes SYNC-4522
pjenvey
force-pushed
the
fix/upgrade-deadpool-SYNC-4522
branch
from
cb16b97 to
040c207
Compare
It's not too bad, I've made all the changes (sorry, earlier I forgot to build locally with |
jrconlin
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which includes a fix for its incorrect metrics:
bikeshedder/deadpool#92
Closes SYNC-4522