feat: add hashed_device_id to HawkIdentifier #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In looking ahead to possible opt-outs, we would want to tether to client logic using the hashed_device_id as a mechanism to delete or exclude records.
See client code : https://searchfox.org/mozilla-central/source/services/sync/modules/telemetry.sys.mjs
This may in the end not be used, but for now it appears to be the best approach and should be included in the data review and payload of the
UserIdentifier, passed in from theHawkPayloadTesting
N/A - unit testing in crates
Issue(s)
Closes SYNC-4448.