feat: add hashed_fxa_uid to HawkPayload #1613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taddes
force-pushed
the
feat/modify-hawk-payload-fxa-id-SYNC-4442
branch
from
afa74d7 to
7315842
Compare
pjenvey
approved these changes
Oct 21, 2024
taddes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of Sync’s authentication flow, Hawk Authentication is used to verify message integrity and authenticity. The
HawkPayloadis generated within Tokenserver and passed to the Syncserver. This contains required fields related to the authorized user/account that is syncing.Presently, the
HawkPayloadin Sync does not process or use thehashed_fxa_uid. We would like this value as part of our DAU measurement, as it is a way of discerning unique sync usage that is not attributable.This requires passing the value to the
HawkPayloadfrom Tokenserver and moving it through the intermediateHawkIdentifierstruct and over into theUserIdentifierstruct, which exposes the value within theMetaRecord.Testing
Internal unit tests
Issue(s)
Closes SYNC-4442.