feat: track the pool's queued vs actually active tasks #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjenvey
commented
Sep 30, 2024
| let blocking_threadpool = Arc::new(BlockingThreadpool::default()); | ||
| let blocking_threadpool = Arc::new(BlockingThreadpool::new( | ||
| settings.worker_max_blocking_threads, | ||
| )); | ||
| let db_pool = DbPoolImpl::new( | ||
| &settings.syncstorage, | ||
| &Metrics::from(&metrics), | ||
| blocking_threadpool.clone(), | ||
| )?; | ||
| let worker_thread_count = | ||
| calculate_worker_max_blocking_threads(settings.worker_max_blocking_threads); |
There was a problem hiding this comment.
In retrospect I don't know why we included worker_ in this setting's name because it's the overall number of threads (not per worker). Whereas the naming of the calculate_worker_max_blocking_threads fn makes sense. I might change it.
pjenvey
force-pushed
the
feat/threadpool-queued-metrics-SYNC-4424
branch
from
cd1803f to
3440a52
Compare
and consider idle threads as a "max" value as the underlying tokio threadpool will exit threads idle for too long Closes SYNC-4424
pjenvey
force-pushed
the
feat/threadpool-queued-metrics-SYNC-4424
branch
from
3440a52 to
f921d8e
Compare
jrconlin
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and consider idle threads as a "max" value as the underlying tokio threadpool will exit threads idle for too long
Closes SYNC-4424