-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to Poetry for Python #1586
base: master
Are you sure you want to change the base?
Conversation
[tool.poetry] | ||
name = "syncstorage-rs" | ||
version = "0.1.0" | ||
description = "sync storage server in rust" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a potential that folk might discover this package while looking for a stand-alone Sync storage server. Let's be exceptionally clear about what this is and how it's being used.
description = "sync storage server in rust" | |
description = "Support package for the Mozilla Sync storage server, written in rust. This is not a 'stand alone' server and is not meant for general use to run your own Sync storage server. Please see [the wiki page](https://github.com/mozilla-services/syncstorage-rs/wiki/overview) for further details." |
b8c0ff2
to
2aa78e2
Compare
d7af2bd
to
fa1df48
Compare
a3673b2
to
c20fcb1
Compare
) | ||
writer = DataFileWriter( | ||
open(out_file_name, "wb"), DatumWriter(), schema) | ||
for chunk in range(max(1, math.trunc(math.ceil(row_count / MAX_ROWS)))): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, i'd have words with the folk behind black and why they want python to look like perl, but 🤷🏻
c20fcb1
to
8d649a8
Compare
Thanks for the comments @jrconlin . I shelved this one before MozWeek, but I don't think it hurts to merge in now, we can pick up the steps later once we've finished our priority tasks. All the parts are there to utilize the tooling with some format improvements, we'll just make the move to Poetry (officially, should we wish) down the road. |
57c08e2
to
3bd2a93
Compare
… matching between subdirectories
3bd2a93
to
d2ff740
Compare
Description
Update to Poetry for Python dependency management.
This puts all the tools, dependencies, and commands in place. However, we won't spin our wheels right now converting over in CI, moving from venv and whatnot, since we're not prioritizing Sync modernization atm. We will address down the road, but for the time being increases developer speed and experience for checks and makes some improvements to the python utilities.
Benefits:
Testing
How should reviewers test?
Issue(s)
Closes 4293.