feat: Add normalized ReportableError to errors #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to do things like add tags and other features to sync errors the way that we do in other packages. To do so, we're backporting ReportableError from Autopush to Syncstorage. This also addresses some clippy fixes required by 1.78 Closes SYNC-4262
* More clippy updates
pjenvey
requested changes
May 13, 2024
…nto feat/SYNC-4262_rep_error
pjenvey
approved these changes
May 17, 2024
| .wrap_fn(middleware::weave::set_weave_timestamp) | ||
| .wrap_fn(tokenserver::logging::handle_request_log_line) | ||
| .wrap_fn(middleware::sentry::report_error) | ||
| //.wrap_fn(middleware::sentry::report_error) |
There was a problem hiding this comment.
Suggested change
| //.wrap_fn(middleware::sentry::report_error) |
| } | ||
|
|
||
| /// Experimental: return key value pairs for Sentry Event's extra data | ||
| /// TODO: should probably return Vec<(&str, Value)> or Vec<(String, Value)> |
There was a problem hiding this comment.
Suggested change
| /// TODO: should probably return Vec<(&str, Value)> or Vec<(String, Value)> |
| // These are our wrappers | ||
| .wrap_fn(middleware::sentry::report_error) | ||
| //.wrap_fn(middleware::sentry::report_error) |
There was a problem hiding this comment.
Suggested change
| //.wrap_fn(middleware::sentry::report_error) |
|
I'll file a quick follow-up PR that has these fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to do things like add tags and other features to sync errors the
way that we do in other packages. To do so, we're backporting
ReportableError from Autopush to Syncstorage.
This also addresses:
Closes SYNC-4262