Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: take keys_changed_at into account w/ migrated records' special case #1545

Merged

Conversation

pjenvey
Copy link
Member

@pjenvey pjenvey commented Apr 25, 2024

and make the comparison more clear/explicit as the goal is to check if the fxa_kids match

Issue SYNC-4225

and make the comparison more clear/explicit as the goal is to check if the
`fxa_kid`s match

Issue SYNC-4225
@pjenvey pjenvey requested review from jrconlin and taddes April 25, 2024 20:34
Copy link
Contributor

@taddes taddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great addition and context.

@pjenvey pjenvey merged commit f68fb60 into master Apr 25, 2024
8 checks passed
@pjenvey pjenvey deleted the feat/migration-record-deletion-SYNC-4225-keys-changed-at branch April 25, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants