bug: Add try/except handler for force #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will wrap the force `delete_service_data` with a try/except handler so as not to prevent the tokenserver record from being removed if the delete_service_data fails.
* Try/except will capture any errors from trying to call the delete on a given node, this could fail if the auth or node aren't correct. * Override will override the attempted node. This will allow us to force the delete message, even if the original data was copied over and the node was incorrect.
taddes
requested changes
Apr 9, 2024
| ), | ||
| }, | ||
| secret=secret, | ||
| ) | ||
| secret = tokenlib.get_derived_secret(token, secret=secret) | ||
| endpoint = PATTERN.format(uid=user.uid, node=user.node) | ||
| auth = HawkAuth(token, secret) |
There was a problem hiding this comment.
Is there a reason we don't do the dryrun check sooner in the function? Just wondering if it's better to exit earlier before making the token.
There was a problem hiding this comment.
Mostly just to exercise code. For a dry run, I prefer doing as much as possible up until I'm about to do something destructive / permanent so that I know that all other aspects/functions work. Ideally, the dryrun would dump state so that could see what the action to be taken would be, but that can produce a lot of noise.
…torage-rs into bug/SYNC-3426_try
pjenvey
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will wrap the force
delete_service_datawith a try/except handlerso as not to prevent the tokenserver record from being removed if the
delete_service_data fails.
override_nodeoption to attempt the delete using the specified node instead of the recorded one. (useful if the original record was copied over and the subsequent managing node changed.)blackto improve formattingIssue(s)
Closes SYNC-3426