Upgrades rustc in CI and Docker to 1.75 #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarikeshaq
force-pushed
the
tarikeshaq/upgrade-rust
branch
from
285932d to
f87293c
Compare
tarikeshaq
changed the title
|
Well, it looks like circle ci image for 1.76 isn't even there yet, so using 1.75 seems like a good call eitherways |
4 tasks
jrconlin
reviewed
Feb 9, 2024
jrconlin
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looks like our Rust version was still 1.72, which is OK, but it seems like cargo-audit now depends on clap 4.5, which itself required 1.74 (see https://app.circleci.com/pipelines/github/mozilla-services/syncstorage-rs/4909/workflows/427c8cef-e69e-46f3-947f-aa9dc61b3353/jobs/18546)
I'm keeping it as a draft till we see the tests pass
Also, It might not be a good idea to upgrade all the way to 1.76, especially since 1.76 just got released today, so I'm open to making this 1.75 (or 1.74)
I also fixed the clippy issues that came with the upgrade