bug: Copy modified purge script from old tokenserver repo #1512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto bug/purge_old_rec
…nto bug/purge_old_rec
jrconlin
force-pushed
the
bug/purge_old_rec
branch
from
c0de9e1 to
a9a6c22
Compare
…nto bug/purge_old_rec
…nto bug/purge_old_rec
|
FINALLY able to dismiss the old review. |
pjenvey
reviewed
Feb 24, 2024
There was a problem hiding this comment.
Maybe it's just Friday but I found the "if settings and ..." a bit confusing so I abandoned the settings addition for yet way more args.
We were also missing this line and wiring up the newer --max-records opt:
pjenvey
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.