chore: upgrade to Rust 1.65 #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethowitz
commented
Nov 18, 2022
| @@ -19,7 +19,7 @@ pub struct TokenserverError { | |||
| /// For internal use only. Used to report any additional context behind an error to | |||
| /// distinguish between similar errors in Sentry. | |||
| pub context: String, | |||
| pub backtrace: Backtrace, | |||
| pub backtrace: Box<Backtrace>, | |||
There was a problem hiding this comment.
The result_large_err clippy lint was saying that TokenserverError was too large. Boxing the backtrace field resolved the issue, but I don't quite understand why. This is the definition of Backtrace:
pub struct Backtrace {
// Frames here are listed from top-to-bottom of the stack
frames: Vec<BacktraceFrame>,
// The index we believe is the actual start of the backtrace, omitting
// frames like `Backtrace::new` and `backtrace::trace`.
actual_start_index: usize,
}Vecs are stored on the heap and usizes are trivially small, so 🤷🏻 it doesn't seem that big to me
There was a problem hiding this comment.
It's because its large-error-threshold is quite small, defaulting to 128.
There was a problem hiding this comment.
Ah, I should have read through the rest of the lint's documentation
pjenvey
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.