feat: don't run Tokenserver migrations on startup #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethowitz
commented
Apr 21, 2022
| @@ -44,10 +44,13 @@ python: | |||
| venv/bin/python -m pip install -r requirements.txt | |||
|
|
|||
| run: python | |||
| PATH=./venv/bin:$(PATH) RUST_LOG=debug RUST_BACKTRACE=full cargo run -- --config config/local.toml | |||
| PATH="./venv/bin:$(PATH)" RUST_LOG=debug RUST_BACKTRACE=full cargo run -- --config config/local.toml | |||
There was a problem hiding this comment.
This fixes an unrelated bug that causes make run to fail if an item in your path has any whitespace characters in it.
added 2 commits
April 21, 2022 18:51
This reverts commit 3cfcbdb.
pjenvey
requested changes
Apr 22, 2022
|
Removed the |
pjenvey
previously approved these changes
Apr 22, 2022
jrconlin
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we're connecting to the pre-existing Tokenserver database, we should not be running the migrations on server startup.