bug: fix Tokenserver migrations #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrations were previously failing in GCP because the `services` table already exists in the database. To rectify this, we needed to change the `CREATE TABLE` statements to `CREATE TABLE IF NOT EXISTS`. We also had to change any `INSERT` statements to `INSERT IGNORE` statements.
jrconlin
approved these changes
Apr 19, 2022
pjenvey
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrations were previously failing in GCP because the
servicestablealready exists in the database. To rectify this, we needed to change the
CREATE TABLEstatements toCREATE TABLE IF NOT EXISTS. We also hadto change any
INSERTstatements toINSERT IGNOREstatements.Testing
I tested this by reverting all the migrations, manually adding the tables and
sync-1.1andsync-1.5services, and running the migrations. The migrations should complete with no errors.