refactor: cache FxA OAuth client #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just ran the load tests against this branch and it had a huge impact on performance: the median request time went from ~800ms to ~11ms 🤯 |
pjenvey
reviewed
Feb 4, 2022
src/tokenserver/support.rs
Outdated
| let code = include_str!("verify.py"); | ||
| let module = PyModule::from_code(py, code, Self::FILENAME, Self::FILENAME)?; | ||
| let kwargs = fxa_oauth_server_url | ||
| .clone() |
There was a problem hiding this comment.
nit: this clone (or alternatively the other in ServerState::from_settings) isn't needed.
pjenvey
approved these changes
Feb 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Caches the PyFxA OAuth client to reduce memory churn and to take advantage of HTTP keep-alive.
Testing
This is covered by the end-to-end integration tests.
Issue(s)
Closes #1209