refactor: remove static service IDs #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrconlin
reviewed
Jan 4, 2022
| cursor = self.database._execute_sql('DELETE FROM users') | ||
| cursor.close | ||
| cursor = self.database._execute_sql('DELETE FROM services') | ||
| cursor.close() |
jrconlin
reviewed
Jan 4, 2022
.circleci/config.yml
Outdated
| @@ -38,7 +38,7 @@ commands: | |||
| command: | | |||
| cargo fmt -- --check | |||
| # https://github.com/bodil/sized-chunks/issues/11 | |||
| cargo audit --ignore RUSTSEC-2020-0041 --ignore RUSTSEC-2021-0078 --ignore RUSTSEC-2021-0079 --ignore RUSTSEC-2020-0159 --ignore RUSTSEC-2020-0071 --ignore RUSTSEC-2021-0124 | |||
| cargo audit --ignore RUSTSEC-2020-0041 --ignore RUSTSEC-2021-0078 --ignore RUSTSEC-2021-0079 --ignore RUSTSEC-2020-0159 --ignore RUSTSEC-2020-0071 --ignore RUSTSEC-2021-0124 --ignore RUSTSEC-2021-0131 | |||
There was a problem hiding this comment.
Let's put these in a .cargo/audit.toml file.
jrconlin
requested changes
Jan 4, 2022
|
@jrconlin Where do you think we should note this? In the code? |
|
I think adding it to the commit message and making sure that it's rolled up into the Changelog should be good. |
jrconlin
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the two statically-defined services from the database via a new migration. Makes updates to the application code and integration tests to reflect the change in schema.
Testing
Passing unit and integration tests should sufficiently show that the change was successful.
Issue(s)
Closes #1144