Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/update 2021 07 #1124

Merged
merged 9 commits into from
Aug 2, 2021
Merged

Chore/update 2021 07 #1124

merged 9 commits into from
Aug 2, 2021

Conversation

jrconlin
Copy link
Member

Description

Update dependencies, rust versions

Testing

No change to function

Issue(s)

NA

@jrconlin jrconlin requested review from ethowitz and a team July 30, 2021 21:57
pjenvey
pjenvey requested changes Jul 31, 2021
View reviewed changes
src/web/extractors.rs Outdated Show resolved Hide resolved
@jrconlin @pjenvey
f use into_owned
3eda5c2 
Co-authored-by: Philip Jenvey <[email protected]>
@jrconlin jrconlin requested a review from pjenvey August 2, 2021 15:29
@jrconlin
Copy link
Member Author

jrconlin commented Aug 2, 2021

(Not why, but rust-analyzer really didn't like into_owned() until I rebuilt everything with a cargo clean. It absolutely wanted me to use either String::from() or to_string() here.)

ethowitz
ethowitz approved these changes Aug 2, 2021
View reviewed changes
Copy link
Contributor

@ethowitz ethowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tokenserver changes look good to me ✅

@jrconlin jrconlin merged commit 9a82b3c into master Aug 2, 2021
@jrconlin jrconlin deleted the chore/update-2021-07 branch August 2, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethowitz ethowitz ethowitz approved these changes

@pjenvey pjenvey pjenvey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrconlin @pjenvey @ethowitz