feat: Add "auto-split" arg to auto-gen UID prefixes #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto feat/1034-auto-split
pjenvey
approved these changes
Apr 2, 2021
| @@ -190,6 +194,14 @@ def get_args(): | |||
| help="Array of strings used to limit purges based on UID. " | |||
| "Each entry is a separate purge run." | |||
| ) | |||
| parser.add_argument( | |||
There was a problem hiding this comment.
Is it worth adding a guard to error out if both auto_split and uid_prefixes are specified?
There was a problem hiding this comment.
If this was a general use tool, absolutely. Since it's in-house, I'm willing to let it slide and just answer any questions SRE might come up with.
If they hit it as a problem, I'll add the guards.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1034
Description
adds
--auto_split/PURGE_AUTO_SPLITarg to auto-genuid_prefixfields for N digits, (e.g.--auto_split=3will generate prefixes of["000","001","002",...,"fff"]Testing
You can use
--dry_runand verify that queries for each prefix are generatedIssue(s)
Closes #1034.